Smart Group for "Buy It Now Price > 999.99" not working


#1

Using GarageSale Version 7.0.14b1 (829), macOS Version 10.12.6 (16G1212)

  1. When clicking the OK button in the rule editor, the Smart Group now gets updated, but the center pane does not.

  1. Commas in the number field seem to cause problems. Open Smart Group to Change number from 999.99 to 1999.99, click OK. Open Smart Group, number is now “1,999.99”, click in “1,999.99” number field, click OK. Open Smart Group, number is now “1”! This field should not allow commas, just like the Buy It Now price field. Maybe this will fix the comparison issue???


  1. I have this Smart Group for only a “Buy It Now Price > 999.99”. I have 1 listing with a 2999.99 price since the conversion from GS6. This Smart Group shows 4 items!


I changed the filter value to > 3999.99 and the 1 (2999.99) item still shows up!


Change the filter back to price > 999.99 and 4 items show up!


#2

That will be fixed in the next beta release.

Sorry, that system behaviour that’s hard to alter. Don’t use thousands separator in that field at all. On the upside, while searching for a solution I found a hack to increase the width of the number field.

Maybe that’s related to #1 in your post? If this still happens with 7.0.14 Beta 2, your indexes might be out of sync.


#3

Using GarageSale Version 7.0.14b3 (831), macOS Version 10.12.6 (16G1212)

I rebuilt indexes yesterday. No difference on my Buy-It-Now Smart Group results. Do you have any logging that I can turn on to see what is going on and help figure this out? Feels like an un-initialized variable???.. :slight_smile:

A few days ago, this Smart Group always showed the same 3 “other” listings that should not have been included. Since yesterday, now it is showing the same 2 “different” listings that should not be included. Very Strange.

If I export these listings, the Buy-It-Now fields ARE correct as displayed, so the actual amounts in the database ARE correct. Just the Smart Group result.

Here are 2 more simple examples:





#4

So… I just changed the title “Lot of 5 20 JK 45 Double Track Viaduct UniTrack, N Scale JK” to “Lot of 5 20 JK 45 Double Track Viaduct UniTrack Tiptronic, N Scale JK”, adding the word “Tiptronic” (just for doing another test) and this listing disappeared from the 2 BIN Smart Groups above!!! VERY STRANGE!!!

And if I open the Smart Group rule editor for those Smart Groups and just click OK, without any changes, this listing shows up again! something definitely weird with the “Buy-It-Now price” filter…


#5

Ilja, Can you add some Smart Group logging???

It seems like “periodic Smart Group updating” and “immediate Smart Group updating by clicking the rule dialog OK button” are doing slightly different evaluations and sometimes are returning different results…


#6

I tried to reproduce this, but failed. Can you please make a screencast that shows the smart group setup for this scenario, as well as the listing disappearing when you change the title.

Can you also send me a screenshot of your number format System Preferences > Language & Region > “Advanced” button?

My gut feeling is that some component is not dealing correctly with number formats here. Since we are using the MacOS runtime method to evaluate smart group membership when you are changing an item, we cannot add much logging here.


#7

OK, so I think this also sounds like it is the issue of using 2 different evaluation engines! Again, 1 consistent evaluation engine would be better…

“I tried to reproduce this, but failed. Can you please make a screencast that shows the smart group setup for this scenario, as well as the listing disappearing when you change the title.”

"Can you also send me a screenshot of your number format System Preferences > Language & Region > “Advanced” button?"
Here ya go:

“My gut feeling is that some component is not dealing correctly with number formats here. Since we are using the MacOS runtime method to evaluate smart group membership when you are changing an item, we cannot add much logging here.”

I THINK the macOS runtime comparison methods seem to be correct.


#8

I wish we could, but that’s not practical. To use Apple’s engine, we’d need to created instances from all objects in the database. If you have 10,000 listings, that could take over a minute.

On the other hand, using our own engine only works on items in the database. If we’d employ it to validate your changes to live items, we’d need to save the listing to the database first, run the queries for all your smart groups, and check if the any of the query result contains that item. That’s too much overhead to be practical.

In that case, you can send me your GarageSale.leveldb library once again as .zip? You can get to it by using the Help > Show Library folder command.

Here is a DropBox from to uploads directly to our disk space:


#9

OK, just uploaded GarageSale.leveldb.zip and GarageSale-FTSIndex.leveldb.zip (not sure if you wanted both).


#10

I THINK that would be OK!
Actually, that would be great, if you can just do it as a background task.
Just like updating orders and listings (which actually takes many minutes).

Can you just do the “updating” on a background thread and let the Smart Groups populate as the progress continues with a small progress bar up near the toolbar.

I know… This is much more effort… :slight_smile: But the current results are not consistent…

Sounds like this would be pretty “quick” for most users with <1000 listings?
And for those of us that have many hundreds or thousands (me >21500) of listings, ACCURACY is VERY important!

This way, there would be consistent results (with 1 and only 1 evaluation engine) between the Search field, Smart Groups filter editor clicking OK, and Smart Groups when changing an item.

“I THINK the macOS runtime comparison methods seem to be correct.”

Yes, the macOS runtime comparison methods would be best.


#11

Thanks for the files. I didn’t have time to fully test the fix I found yet, but it seems to be better than before.

  1. Please download this version:
    http://downloads.iwascoding.com/downloads/GarageSale_7_2018-03-14.dmg

  2. Start it with the control key and check the “Rebuild indexes box”

  3. Once the rebuilding is done, go through the smart groups with a Buy It Now Price rule and click “OK”

Are results correct when you editing BIN prices now?


#12

YES!!!

OK, Rebuild took just over 30 minutes…

“Once the rebuilding is done, go through the smart groups with a Buy It Now Price rule and click “OK””

OK, done. Also did all Smart Groups with “Starting Bid” and “Reserve Price” filters.

“Are results correct when you editing BIN prices now?”

YES!!! Smart Group results for Buy-It-Now prices now seem to work correctly! Upon app launch, when editing listing BIN prices, AND when editing Smart Group rules.

THANK YOU!!

Case Closed.


#13